-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vcs links to be static #2304
Fix vcs links to be static #2304
Conversation
this will fix the pre-commit run Fixes tektoncd#2303 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-cli-build-tests |
1 similar comment
/test pull-tekton-cli-build-tests |
@chmouel: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Error is
|
@@ -55,7 +55,7 @@ dnf upgrade tektoncd-cli | |||
|
|||
- Make an update on [homebrew-core](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb) for tektoncd-cli formula. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also needs update
|
||
|
||
- Go to https://archlinux.org/packages/community/x86_64/tekton-cli/flag/ and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it. | ||
- Go to <https://archlinux.org/packages/community/x86_64/tekton-cli/flag/> and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be https://archlinux.org/packages/extra/x86_64/tekton-cli/flag/
@chmouel: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this will fix the pre-commit run
Fixes #2303
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com